harshmotw-db commented on code in PR #49080:
URL: https://github.com/apache/spark/pull/49080#discussion_r1876805617
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -96,6 +96,13 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog with QueryErrorsB
case _ => None
}
+ protected def variantExprInPartitionExpression(plan: LogicalPlan):
Option[Expression] =
Review Comment:
That could be quite risky considering several Spark workloads could
currently be repartitioning by map types. It's fine for Variant as Variant is a
new feature.
Also, broken "repartitioning" isn't a correctness problem since query
results should be agnostic of the partitioning right? I think it would result
in suboptimal performance at worst.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
