hvanhovell commented on code in PR #49080:
URL: https://github.com/apache/spark/pull/49080#discussion_r1876821086
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -96,6 +96,13 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog with QueryErrorsB
case _ => None
}
+ protected def variantExprInPartitionExpression(plan: LogicalPlan):
Option[Expression] =
Review Comment:
@harshmotw-db no it will be an actual correctness issue. The problem - like
with variant - is that the order of key-value pairs in a map is undefined, e.g.
`Map(a ->b, b -> c) == Map(b -> c, a -> b)`. However this is not your problem.
Your point about it being a problem for existing workloads is correct, however
that would only mean we would have to add a feature flag. cc @cloud-fan
@HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
