cloud-fan commented on code in PR #49084:
URL: https://github.com/apache/spark/pull/49084#discussion_r1896533226
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala:
##########
@@ -232,6 +232,16 @@ class DataTypeAstBuilder extends
SqlBaseParserBaseVisitor[AnyRef] {
visitMultipartIdentifier(ctx.collationName)
}
+ protected def visitCollationSpecList(
+ ctx: java.util.List[CollationSpecContext]): Option[String] = {
+ ctx.asScala.headOption.map(visitCollationSpec)
+ }
+
+ override def visitCollationSpec(ctx: CollationSpecContext): String =
withOrigin(ctx) {
Review Comment:
How are these two methods related to `DataTypeAstBuilder`? They are for
Spark DDL commands and should be put in `AstBuilder` I think, the same as other
CREATE TABLE/VIEW clauses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
