dejankrak-db commented on code in PR #49084:
URL: https://github.com/apache/spark/pull/49084#discussion_r1897053997
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -119,6 +119,13 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
clusterBySpecOpt.getOrElse(ClusterBySpec(Nil)), conf.resolver))
AlterTableSetPropertiesCommand(table.catalogTable.identifier, prop,
isView = false)
+ case AlterTableCollation(ResolvedTable(catalog, _, table: V1Table, _),
collation)
Review Comment:
@cloud-fan, actually this exposed a bug in v2AlterTableCommands
implementation of AlterTableCollation(), which was not setting the collation
properly for existing tables. I have changed this code to use setProperty
instead (similar to how other table catalog props are altered), and added a
test case in v2/DescribeTableSuite to ensure that this path now works correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
