cloud-fan commented on code in PR #49084:
URL: https://github.com/apache/spark/pull/49084#discussion_r1896537523


##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -119,6 +119,13 @@ class ResolveSessionCatalog(val catalogManager: 
CatalogManager)
         clusterBySpecOpt.getOrElse(ClusterBySpec(Nil)), conf.resolver))
       AlterTableSetPropertiesCommand(table.catalogTable.identifier, prop, 
isView = false)
 
+    case AlterTableCollation(ResolvedTable(catalog, _, table: V1Table, _), 
collation)

Review Comment:
   Since this is a new feature, I think we can directly go with the v2 command. 
i.e. do not match this command here, and eventually Spark will plan it as 
`AlterTableExec`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to