cloud-fan commented on code in PR #49210:
URL: https://github.com/apache/spark/pull/49210#discussion_r1904904517


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala:
##########
@@ -330,7 +330,8 @@ object Uniform {
   group = "string_funcs")
 case class RandStr(
     length: Expression, override val seedExpression: Expression, hideSeed: 
Boolean)
-  extends ExpressionWithRandomSeed with BinaryLike[Expression] with 
Nondeterministic {
+  extends ExpressionWithRandomSeed with BinaryLike[Expression] with 
Nondeterministic
+    with ExpectsInputTypes {

Review Comment:
   Then how do we perform type coercion for the non-seed inputs? Shall we 
follow the behavior of ansi Cast or non-ansi Cast?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to