cloud-fan commented on code in PR #49210:
URL: https://github.com/apache/spark/pull/49210#discussion_r1906462083
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala:
##########
@@ -366,52 +371,45 @@ case class RandStr(
}
override def checkInputDataTypes(): TypeCheckResult = {
- var result: TypeCheckResult = TypeCheckResult.TypeCheckSuccess
- def requiredType = "INT or SMALLINT"
- Seq((length, "length", 0),
- (seedExpression, "seed", 1)).foreach {
- case (expr: Expression, name: String, index: Int) =>
- if (result == TypeCheckResult.TypeCheckSuccess) {
- if (!expr.foldable) {
- result = DataTypeMismatch(
- errorSubClass = "NON_FOLDABLE_INPUT",
- messageParameters = Map(
- "inputName" -> toSQLId(name),
- "inputType" -> requiredType,
- "inputExpr" -> toSQLExpr(expr)))
- } else expr.dataType match {
- case _: ShortType | _: IntegerType =>
- case _: LongType if index == 1 =>
- case _ =>
- result = DataTypeMismatch(
- errorSubClass = "UNEXPECTED_INPUT_TYPE",
- messageParameters = Map(
- "paramIndex" -> ordinalNumber(index),
- "requiredType" -> requiredType,
- "inputSql" -> toSQLExpr(expr),
- "inputType" -> toSQLType(expr.dataType)))
- }
+ var result: TypeCheckResult = super.checkInputDataTypes()
+ Seq((length, "length"),
+ (seedExpression, "seed")).foreach {
+ case (expr: Expression, name: String) =>
+ if (result == TypeCheckResult.TypeCheckSuccess && !expr.foldable) {
+ result = DataTypeMismatch(
+ errorSubClass = "NON_FOLDABLE_INPUT",
+ messageParameters = Map(
+ "inputName" -> toSQLId(name),
+ "inputType" -> "integer",
+ "inputExpr" -> toSQLExpr(expr)))
}
}
result
}
override def evalInternal(input: InternalRow): Any = {
- val numChars = length.eval(input).asInstanceOf[Number].intValue()
+ val numChars = lengthInteger()
ExpressionImplUtils.randStr(rng, numChars)
}
+ private def lengthInteger(): Int = {
+ val result = Cast(length, IntegerType).eval().asInstanceOf[Int]
Review Comment:
This is a bit hard for native engines to follow. Shall we match `RandStr` in
`FunctionArgumentTypeCoercion` to add cast for the length input?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
