gengliangwang commented on code in PR #49210:
URL: https://github.com/apache/spark/pull/49210#discussion_r1907999298
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala:
##########
@@ -330,7 +330,8 @@ object Uniform {
group = "string_funcs")
case class RandStr(
length: Expression, override val seedExpression: Expression, hideSeed:
Boolean)
- extends ExpressionWithRandomSeed with BinaryLike[Expression] with
Nondeterministic {
+ extends ExpressionWithRandomSeed with BinaryLike[Expression] with
Nondeterministic
+ with ExpectsInputTypes {
Review Comment:
I got the same question here: why just simply extending
`ImplicitCastInputTypes`?
> the existing RAND and RANDN functions extend ExpectsInputTypes and return
errors when we try to pass numeric values other than IntegerType or LongType
Since we are going to make a difference in this PR, RandStr doesn't have to
be consistent with RAND and RANDN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
