davidm-db commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1928394636
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNode.scala:
##########
@@ -177,6 +175,25 @@ class NoOpStatementExec extends LeafStatementExec {
override def reset(): Unit = ()
}
+class TriggerHandlerMap(
+ conditionHandlerMap: Map[String, ErrorHandlerExec],
+ sqlStateHandlerMap: Map[String, ErrorHandlerExec],
Review Comment:
And also here then, let's use the "\<x\>To\<y\>Map" format
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNode.scala:
##########
@@ -177,6 +175,25 @@ class NoOpStatementExec extends LeafStatementExec {
override def reset(): Unit = ()
}
+class TriggerHandlerMap(
+ conditionHandlerMap: Map[String, ErrorHandlerExec],
+ sqlStateHandlerMap: Map[String, ErrorHandlerExec],
Review Comment:
And also here then, let's use the "\<x\>To\<y\>Map" format for parameter
names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]