davidm-db commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1928402411
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreter.scala:
##########
@@ -95,8 +95,15 @@ case class SqlScriptingInterpreter(session: SparkSession) {
.map(new SingleStatementExec(_, Origin(), args, isInternal = true,
context))
.reverse
- // Create a map of conditions (SqlStates) to their respective handlers.
- val conditionHandlerMap = HashMap[String, ErrorHandlerExec]()
+ // Map of conditions to their respective handlers.
+ val conditionHandlerMap: HashMap[String, ErrorHandlerExec] = HashMap.empty
+ // Map of SqlStates to their respective handlers.
+ val sqlStateHandlerMap: HashMap[String, ErrorHandlerExec] = HashMap.empty
+ // NOT FOUND handler.
+ var notFoundHandler: Option[ErrorHandlerExec] = None
+ // Get SQLEXCEPTION handler.
+ var sqlExceptionHandler: Option[ErrorHandlerExec] = None
Review Comment:
also here, let's use the `\<x\>To\<y\>Map` format for the variable names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
