Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6479#issuecomment-108680395
There may be some additional cleanup tasks to perform in terms of deleting
old code / workarounds that were needed for quasiquotes but not by Janino. For
example:
```scala
// These classes are here to avoid issues with serialization and
integration with quasiquotes.
class IntegerHashSet extends
org.apache.spark.util.collection.OpenHashSet[Int]
class LongHashSet extends org.apache.spark.util.collection.OpenHashSet[Long]
```
There's a `globalLock`, which I think is Scala's reflection lock, that's
used in the CacheBuilder:
```scala
protected val cache = CacheBuilder.newBuilder()
.maximumSize(1000)
.build(
new CacheLoader[InType, OutType]() {
override def load(in: InType): OutType = globalLock.synchronized {
```
Do we still need this lock?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
