Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6479#issuecomment-108714012
@JoshRosen I think it's fine to keep the global lock, because we want to
only compile once for a given expression. Also the `ClassBodyEvaluator` is not
thread safe, or we need to create new one for each compile unit.
IntegerHashSet is specified version for codegen, it will have better
performance than OpenHashSet[Row].
There is a follow up PR (based on this one) to push the codegen into
Expression, lots of code will be moved, so some minor issues could be addressed
in that one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
