Kimahriman commented on code in PR #50006:
URL: https://github.com/apache/spark/pull/50006#discussion_r1962440576
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -313,4 +314,21 @@ object Connect {
.internal()
.booleanConf
.createWithDefault(true)
+
+ val CONNECT_AUTHENTICATE_TOKEN =
+ buildStaticConf("spark.connect.authenticate.token")
Review Comment:
Yeah I wasn't sure, just modeled after `spark.authenticate`, which itself
makes sense as a verb, but then there's `spark.authenticate.secret`. Initially
I had this as `spark.connect.authenticate.secret`, but then changed it to
`token`. I don't have a strong preference. Could go back to
`spark.connect.authenticate.secret` for consistency, or change to
`spark.connect.authentication.token`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
