HyukjinKwon commented on code in PR #50006:
URL: https://github.com/apache/spark/pull/50006#discussion_r1962495059


##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -313,4 +314,21 @@ object Connect {
       .internal()
       .booleanConf
       .createWithDefault(true)
+
+  val CONNECT_AUTHENTICATE_TOKEN =
+    buildStaticConf("spark.connect.authenticate.token")

Review Comment:
   > https://github.com/apache/spark/pull/49880#discussion_r1952889051
   
   I also still don't like it to be as a conf. Are we sure that this is not 
shown in `ps`? Those will be passed to Spark Submit through Py4J server 
launcher to start Spark Connect server.
   
   This is different in other cases because it will be always down in `ps` 
command vs other configurations are set in spark.conf file in general.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to