HyukjinKwon commented on code in PR #50006:
URL: https://github.com/apache/spark/pull/50006#discussion_r1962485140
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -313,4 +314,21 @@ object Connect {
.internal()
.booleanConf
.createWithDefault(true)
+
+ val CONNECT_AUTHENTICATE_TOKEN =
+ buildStaticConf("spark.connect.authenticate.token")
+ .doc("A pre-shared token that will be used to authenticate clients. This
secret must be" +
+ " passed as a bearer token by for clients to connect.")
+ .version("4.0.0")
+ .internal()
+ .stringConf
+ .createOptional
+
+ val CONNECT_AUTHENTICATE_TOKEN_ENV = "SPARK_CONNECT_AUTHENTICATE_TOKEN"
+
+ def getAuthenticateToken: Option[String] = {
+ SparkEnv.get.conf.get(CONNECT_AUTHENTICATE_TOKEN).orElse {
+ sys.env.get(CONNECT_AUTHENTICATE_TOKEN_ENV)
Review Comment:
Let's avoid `sys.env`. This creates a map internally for all environment
variables, and it's actually pretty slow. Let's use System.getenv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
