HeartSaVioR commented on code in PR #50015:
URL: https://github.com/apache/spark/pull/50015#discussion_r1963107942
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala:
##########
@@ -128,11 +130,39 @@ class QueryExecution(
case _ => "command"
}
+ private def assertNoStreamSourceMarkerNode(p: LogicalPlan): Unit = {
+ // In UnsupportedOperationChecker.checkForBatch, we check if the plan has
any streaming node.
+ // That is more aggressive than just checking the marker node for
streaming source which is
+ // yet to be materialized. We'd like to be a bit conservative here since
this is the exact
+ // problematic case we figured out.
+ p.foreach {
Review Comment:
Yeah... LeafRunnableCommand doesn't seem to be something we could deal with
it in general (as there is no general interface to look at underlying query).
We could only deal with it when LeafRunnableCommand runs another query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
