viirya commented on PR #50015: URL: https://github.com/apache/spark/pull/50015#issuecomment-2672160946
> I realized the downside of the fix - if we were ever planning to unify the logical plan for write between batch and streaming (at least DSv2 path), it wouldn't work. For now, streaming write node is always either WriteToMicroBatchDataSource or WriteToMicroBatchDataSourceV1, so wouldn't be problematic with this change. What does it mean? I saw you don't check WriteToMicroBatchDataSource or WriteToMicroBatchDataSourceV1 but streaming relations like StreamingRelation, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
