cloud-fan commented on code in PR #50015:
URL: https://github.com/apache/spark/pull/50015#discussion_r1963236842
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala:
##########
@@ -422,6 +422,24 @@ class QueryExecutionSuite extends SharedSparkSession {
mockCallback.assertAnalyzed()
}
+ test("SPARK-51265 Running eagerlyExecuteCommand with streaming source should
give an user " +
+ "facing error") {
+ withTempView("s") {
+ val streamDf = spark.readStream.format("rate").load()
+ streamDf.createOrReplaceTempView("s")
+ withTable("output") {
+ val ex = intercept[AnalysisException] {
+ // Creates a table from streaming source with batch query. This
should fail.
+ spark.sql("CREATE TABLE output AS SELECT * FROM s")
Review Comment:
So before this PR, this test fails with stack overflow?
If the stack overflow issue is fixed, `InsertIntoHadoopFsRelationCommand`
will hit `UnsupportedOperationChecker` and we are fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
