Kimahriman commented on PR #50006:
URL: https://github.com/apache/spark/pull/50006#issuecomment-2675251514

   > @Kimahriman for scala you probably need to change 
`org.apache.spark.sql.connect.client.SparkConnectClient.Configuration.credentials`.
 If you don't want SSL I guess you can compose `InsecureChannelCredentials` 
with `CallCredentials`, but I frankly have no idea if that satisfies the 
requirements, and if it is even allowed by gRPC.
   
   Yep it is not allowed by gRPC. The Java library doesn't have the equivalent 
`LocalChannelCredentials` as the Python library: 
https://github.com/grpc/grpc-java/issues/9900
   
   Was able to work around this by simply passing in the metadata through the 
interceptor if the host is localhost, let me know what you think.
   
   I also had to make some updates around the assertions for tokens and SSL on 
the client setup, and changed it to act like the Python setup, where TLS is 
used by default if you have a token set, unless you're talking to localhost, 
and no checks are made on the options you try to use


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to