HyukjinKwon commented on code in PR #50006:
URL: https://github.com/apache/spark/pull/50006#discussion_r1962571359
##########
python/pyspark/sql/connect/client/core.py:
##########
@@ -220,7 +220,9 @@ def userId(self) -> Optional[str]:
@property
def token(self) -> Optional[str]:
- return self._params.get(ChannelBuilder.PARAM_TOKEN, None)
+ return self._params.get(
+ ChannelBuilder.PARAM_TOKEN,
os.environ.get("SPARK_CONNECT_AUTHENTICATE_TOKEN")
Review Comment:
We should probably don't set this if
`os.environ.get("SPARK_CONNECT_AUTHENTICATE_TOKEN")` is `None` because we will
not use this when this auth is off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
