peter-toth commented on code in PR #51534:
URL: https://github.com/apache/spark/pull/51534#discussion_r2213662391
##########
sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala:
##########
@@ -78,8 +78,8 @@ trait PlanStabilitySuite extends
DisableAdaptiveExecutionSuite {
}
private val referenceRegex = "#\\d+".r
- private val normalizeRegex = "#\\d+L?".r
- private val planIdRegex = "plan_id=\\d+".r
+ private val exprIdRegexp = "(?<prefix>(?<!id=)#)\\d+L?".r
Review Comment:
The `(?<!id=)` part is a negative lookbehind to not match `id=#123` but
match all other `#123` like expr ids as `id=#123` are actually plan ids in
`SubqueryExec` nodes.
The`(?<prefix>` capture group just simplifies replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
