cloud-fan commented on code in PR #51534:
URL: https://github.com/apache/spark/pull/51534#discussion_r2214053103
##########
sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala:
##########
@@ -78,8 +78,8 @@ trait PlanStabilitySuite extends
DisableAdaptiveExecutionSuite {
}
private val referenceRegex = "#\\d+".r
- private val normalizeRegex = "#\\d+L?".r
- private val planIdRegex = "plan_id=\\d+".r
+ private val exprIdRegexp = "(?<prefix>(?<!id=)#)\\d+L?".r
Review Comment:
> id=#123 like ids are actually plan ids in SubqueryExec nodes.
Ah I didn't know it. Can we leave a code comment to explain it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
