peter-toth commented on code in PR #51534:
URL: https://github.com/apache/spark/pull/51534#discussion_r2213687154
##########
sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala:
##########
@@ -78,8 +78,8 @@ trait PlanStabilitySuite extends
DisableAdaptiveExecutionSuite {
}
private val referenceRegex = "#\\d+".r
- private val normalizeRegex = "#\\d+L?".r
- private val planIdRegex = "plan_id=\\d+".r
+ private val exprIdRegexp = "(?<prefix>(?<!id=)#)\\d+L?".r
Review Comment:
The problem in some subset test runs was, that an id did show up in the plan
both as plan id and as expression id. So the previous `exprIdRegexp` replaced
all occurances to the same normalized one.
But in the golden run the ids were different so `exprIdRegexp` and
`planIdRegex` replaced to 2 different normalized ids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
