dusantism-db commented on code in PR #51595:
URL: https://github.com/apache/spark/pull/51595#discussion_r2222601238
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -565,6 +566,7 @@ class AstBuilder extends DataTypeAstBuilder
isScope = false
)
parsingCtx.labelContext.exitLabeledScope(Option(ctx.beginLabel()))
+ parsingCtx.labelContext.exitForScope(Option(ctx.multipartIdentifier()))
Review Comment:
Considering we enter FOR scope after labeled scope, it makes more sense to
me to leave the FOR scope before we leave the labeled scope, since we consider
it the inner one in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
