davidm-db commented on code in PR #51595:
URL: https://github.com/apache/spark/pull/51595#discussion_r2222769039
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/SqlScriptingErrors.scala:
##########
@@ -30,10 +30,21 @@ import org.apache.spark.sql.internal.SQLConf
*/
private[sql] object SqlScriptingErrors {
+ def forVariableNameAlreadyExistsAsLabelInScope(
+ origin: Origin,
+ varName: String): Throwable = {
+ new SqlScriptingException(
+ origin = origin,
+ errorClass = "FOR_VARIABLE_NAME_FORBIDDEN.NAME_ALREADY_IN_USE",
+ cause = null,
+ messageParameters = Map("varName" -> toSQLId(varName)))
+ }
+
+
def duplicateLabels(origin: Origin, label: String): Throwable = {
new SqlScriptingException(
origin = origin,
- errorClass = "LABEL_ALREADY_EXISTS",
+ errorClass = "LABEL_OR_FOR_VARIABLE_ALREADY_EXISTS",
Review Comment:
Same as in `error-conditions`, this is a breaking change. Let's wait for
replies there and then figure out what to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
