davidm-db commented on code in PR #51595:
URL: https://github.com/apache/spark/pull/51595#discussion_r2222738062
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -4051,9 +4064,9 @@
],
"sqlState" : "42K0L"
},
- "LABEL_ALREADY_EXISTS" : {
+ "LABEL_OR_FOR_VARIABLE_ALREADY_EXISTS" : {
Review Comment:
cc @srielau @cloud-fan changing the error condition is considered a breaking
change, but does the same hold for changing the message?
Depending on the reply here, I'd keep the same name because it clearly
states that label name already exists, but change the message if possible to
explain where.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
