dongjoon-hyun commented on code in PR #52009:
URL: https://github.com/apache/spark/pull/52009#discussion_r2274307253
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala:
##########
@@ -94,8 +94,10 @@ trait OrcTest extends QueryTest with FileBasedDataSourceTest
with BeforeAndAfter
* Orc file will be dropped/deleted after `f` returns.
*/
protected def withOrcTable[T <: Product: ClassTag: TypeTag]
- (data: Seq[T], tableName: String, testVectorized: Boolean = true)
- (f: => Unit): Unit = withDataSourceTable(data, tableName,
testVectorized)(f)
+ (data: Seq[T], tableName: String, testVectorized: Boolean = true
+ , partitionNames: Seq[String] = Seq.empty)
Review Comment:
indentation.
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala:
##########
@@ -94,8 +94,10 @@ trait OrcTest extends QueryTest with FileBasedDataSourceTest
with BeforeAndAfter
* Orc file will be dropped/deleted after `f` returns.
*/
protected def withOrcTable[T <: Product: ClassTag: TypeTag]
- (data: Seq[T], tableName: String, testVectorized: Boolean = true)
- (f: => Unit): Unit = withDataSourceTable(data, tableName,
testVectorized)(f)
+ (data: Seq[T], tableName: String, testVectorized: Boolean = true
+ , partitionNames: Seq[String] = Seq.empty)
+ (f: => Unit): Unit = withDataSourceTable(data, tableName, testVectorized
+ , partitionNames)(f)
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
