dongjoon-hyun commented on code in PR #52009: URL: https://github.com/apache/spark/pull/52009#discussion_r2274294216
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/orc/OrcScan.scala: ########## @@ -45,14 +47,20 @@ case class OrcScan( options: CaseInsensitiveStringMap, pushedAggregate: Option[Aggregation] = None, pushedFilters: Array[Filter], - partitionFilters: Seq[Expression] = Seq.empty, - dataFilters: Seq[Expression] = Seq.empty) extends FileScan { + originPartitionFilters: Seq[Expression] = Seq.empty, + dataFilters: Seq[Expression] = Seq.empty) extends FileScan with SupportsRuntimeV2Filtering { override def isSplitable(path: Path): Boolean = { // If aggregate is pushed down, only the file footer will be read once, // so file should not be split across multiple tasks. pushedAggregate.isEmpty } + private var dppPartitionFilters: Seq[Expression] = Seq.empty; Review Comment: We don't need `;` in Scala code, @flaming-archer . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org