flaming-archer commented on PR #52009: URL: https://github.com/apache/spark/pull/52009#issuecomment-3231753397
> Sorry for being late, @flaming-archer . I was on vacation since 8/15 until this Monday.对不起迟到了，。我从 8 月 15 日到本周一一直在度假。 > > While revisiting your contribution, I'd like to recommend you to make a Parquet PR first to get more community attentions and to enlarge the impact of your contributions.在重新审视您的贡献时，我想建议您先进行 Parquet PR，以获得更多社区关注并扩大您的贡献的影响力。 > > > In fact, I also rewrote ParquetScan with the same code can work. But I haven't figured out how to change these two classes together yet. Or rewrite a class so that both inherit it.事实上，我也用相同的代码重写了 ParquetScan 也可以工作。但我还没有想出如何将这两个类一起改变。或者重写一个类，以便两者都继承它。 > > As you know, `Parquet` is the Apache Spark's default file-based source format. Most test coverages are based on `Parquet` features. So, your contribution will be tested fully if you make a Parquet PR first. After than, we can come back to the other data sources like ORC (this PR).如您所知，`Parquet` 是 Apache Spark 默认的基于文件的源格式。大多数测试覆盖率都基于 `Parquet` 功能。因此，如果您先进行 Parquet PR，您的贡献将得到充分测试。之后，我们可以回到其他数据源，如 ORC（此 PR）。 > > https://github.com/apache/spark/blob/0c9af991ca287c6e21fbada9bd15c04b173ebe89/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L1838-L1842 No problem, I will submit a Parquet version later in the next day or two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
