alekjarmov commented on code in PR #52127:
URL: https://github.com/apache/spark/pull/52127#discussion_r2304257781


##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DB2IntegrationSuite.scala:
##########
@@ -88,6 +93,20 @@ class DB2IntegrationSuite extends DockerJDBCIntegrationSuite 
with SharedJDBCInte
     assert(types(1).equals("class java.lang.String"))
   }
 
+  test("SPARK-53386: Parameter `query` should work when ending with semicolons 
db2") {

Review Comment:
   This test is actually less general and would fail on other suites since it 
assumes existence of the table `tbl` and not every suite has it, and currently 
we don't have a nice way to synchronize data preparation across all connectors 
so I think it's better to go this way, since we override only 1 test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to