urosstan-db commented on code in PR #52127:
URL: https://github.com/apache/spark/pull/52127#discussion_r2304486986
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/SharedJDBCIntegrationTests.scala:
##########
@@ -31,4 +31,20 @@ trait SharedJDBCIntegrationTests extends QueryTest {
}
assert(e.getCondition.startsWith("JDBC_EXTERNAL_ENGINE_SYNTAX_ERROR"))
}
+
+ val queryForSemicolonTest: String = "SELECT 1 as id"
Review Comment:
Overriding the query for a specific test like this one is a litte bit weird
to see, we currently don't have table option, but we would need it at some
time, since generic tests without common table would test only some edge cases.
Can we make `beforeAll() { createTestTable }`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
