urosstan-db commented on code in PR #52127:
URL: https://github.com/apache/spark/pull/52127#discussion_r2304365713
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/SharedJDBCIntegrationTests.scala:
##########
@@ -31,4 +31,20 @@ trait SharedJDBCIntegrationTests extends QueryTest {
}
assert(e.getCondition.startsWith("JDBC_EXTERNAL_ENGINE_SYNTAX_ERROR"))
}
+
+ val queryForSemicolonTest: String = "SELECT 1 as id"
Review Comment:
This is a little bit weird to see we have override for such thing, can you
make `SELECT 1 as ID FROM tbl` a default one and introduce test table name
variable in base suite. We will for sure need it in the future, since we will
have tests which selects from some table which is common for all JDBC
connectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
