miland-db commented on code in PR #52371: URL: https://github.com/apache/spark/pull/52371#discussion_r2388397859
########## sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNode.scala: ########## @@ -1015,11 +1027,6 @@ class ForStatementExec( private var bodyWithVariables: Option[CompoundBodyExec] = None - /** - * For can be interrupted by LeaveStatementExec - */ - private var interrupted: Boolean = false - Review Comment: Let's add comment before `hasNext` to explain where is interrupted used. In this case it is used by `EXIT` and `CONTINUE` handler. I am not sure if some weird chaining of handlers could introduce any problems. If there are no tests with `FOR` and different handlers, let's add them so we are sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
