cloud-fan commented on code in PR #52428:
URL: https://github.com/apache/spark/pull/52428#discussion_r2443656539
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -927,6 +929,10 @@ lateralView
: LATERAL VIEW (OUTER)? qualifiedName LEFT_PAREN (expression (COMMA
expression)*)? RIGHT_PAREN tblName=identifier (AS? colName+=identifier (COMMA
colName+=identifier)*)?
;
+watermarkClause
+ : WATERMARK colName=namedExpression DELAY OF delay=interval
Review Comment:
BTW, `namedExpression` does not guarantee the expression to be named, we
should explicit match `multipartIdentifier | expression AS
errorCapturingIdentifier`
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -927,6 +929,10 @@ lateralView
: LATERAL VIEW (OUTER)? qualifiedName LEFT_PAREN (expression (COMMA
expression)*)? RIGHT_PAREN tblName=identifier (AS? colName+=identifier (COMMA
colName+=identifier)*)?
;
+watermarkClause
+ : WATERMARK colName=namedExpression DELAY OF delay=interval
Review Comment:
BTW, `namedExpression` does not guarantee the expression to be named, we
should explicitly match `multipartIdentifier | expression AS
errorCapturingIdentifier`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
