cloud-fan commented on code in PR #52428:
URL: https://github.com/apache/spark/pull/52428#discussion_r2447389494
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala:
##########
@@ -566,6 +566,23 @@ package object dsl extends SQLConfHelper {
}
def deduplicate(colNames: Attribute*): LogicalPlan =
Deduplicate(colNames, logicalPlan)
+
+ def watermark(expr: Expression, delayThreshold: CalendarInterval):
LogicalPlan = {
+ val namedExpression = expr match {
+ case e: NamedExpression => e
+ case e: Expression => UnresolvedAlias(e)
Review Comment:
shall we fail here? It's a test and we should require the test to name the
event time expr always
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
