cloud-fan commented on code in PR #52428: URL: https://github.com/apache/spark/pull/52428#discussion_r2447381452
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveEventTimeWatermark.scala: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.analysis + +import org.apache.spark.sql.AnalysisException +import org.apache.spark.sql.catalyst.plans.logical.{EventTimeWatermark, LogicalPlan, Project} +import org.apache.spark.sql.catalyst.rules.Rule +import org.apache.spark.sql.catalyst.trees.TreePattern + +/** + * Resolve [[UnresolvedEventTimeWatermark]] to [[EventTimeWatermark]]. + */ +object ResolveEventTimeWatermark extends Rule[LogicalPlan] { + override def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperatorsUpWithPruning( + _.containsPattern(TreePattern.UNRESOLVED_EVENT_TIME_WATERMARK), ruleId) { + + case u: UnresolvedEventTimeWatermark if u.eventTimeColExpr.resolved && u.childrenResolved => + if (u.eventTimeColExpr.isInstanceOf[MultiAlias]) { + throw new AnalysisException( + errorClass = "CANNOT_USE_MULTI_ALIASES_IN_WATERMARK_CLAUSE", + messageParameters = Map() + ) + } + + val uuid = java.util.UUID.randomUUID() + + if (u.child.outputSet.contains(u.eventTimeColExpr)) { + // We don't need to have projection since the attribute being referenced will be available. + EventTimeWatermark(uuid, u.eventTimeColExpr.toAttribute, u.delay, u.child) + } else { + // We need to inject projection as we can't find the matching column directly in the + // child output. + val proj = Project(Seq(u.eventTimeColExpr) ++ u.child.output, u.child) + val attrRef = u.eventTimeColExpr.toAttribute Review Comment: nit: let's move it before the `if-else`, as we need it in the `if` branch as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
