pan3793 commented on code in PR #52741: URL: https://github.com/apache/spark/pull/52741#discussion_r2464377483
########## sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectDatabaseMetaData.scala: ########## @@ -543,21 +443,17 @@ class SparkConnectDatabaseMetaData(conn: SparkConnectConnection) extends Databas override def getJDBCMinorVersion: Int = 3 - override def getSQLStateType: Int = - throw new SQLFeatureNotSupportedException + override def getSQLStateType: Int = DatabaseMetaData.sqlStateSQL - override def locatorsUpdateCopy: Boolean = - throw new SQLFeatureNotSupportedException + override def locatorsUpdateCopy: Boolean = false override def supportsStatementPooling: Boolean = false override def getRowIdLifetime: RowIdLifetime = RowIdLifetime.ROWID_UNSUPPORTED - override def supportsStoredFunctionsUsingCallSyntax: Boolean = - throw new SQLFeatureNotSupportedException + override def supportsStoredFunctionsUsingCallSyntax: Boolean = false - override def autoCommitFailureClosesAllResultSets: Boolean = - throw new SQLFeatureNotSupportedException + override def autoCommitFailureClosesAllResultSets: Boolean = false Review Comment: this is related to transactions, Databricks JDBC v1.0.10-oss returns `true` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
