pan3793 commented on code in PR #52741:
URL: https://github.com/apache/spark/pull/52741#discussion_r2464375374
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectDatabaseMetaData.scala:
##########
@@ -199,164 +162,114 @@ class SparkConnectDatabaseMetaData(conn:
SparkConnectConnection) extends Databas
override def getCatalogSeparator: String = "."
- override def supportsSchemasInDataManipulation: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsSchemasInDataManipulation: Boolean = true
- override def supportsSchemasInProcedureCalls: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsSchemasInProcedureCalls: Boolean = true
- override def supportsSchemasInTableDefinitions: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsSchemasInTableDefinitions: Boolean = true
- override def supportsSchemasInIndexDefinitions: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsSchemasInIndexDefinitions: Boolean = true
override def supportsSchemasInPrivilegeDefinitions: Boolean =
throw new SQLFeatureNotSupportedException
- override def supportsCatalogsInDataManipulation: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsCatalogsInDataManipulation: Boolean = true
- override def supportsCatalogsInProcedureCalls: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsCatalogsInProcedureCalls: Boolean = true
- override def supportsCatalogsInTableDefinitions: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsCatalogsInTableDefinitions: Boolean = true
- override def supportsCatalogsInIndexDefinitions: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsCatalogsInIndexDefinitions: Boolean = true
override def supportsCatalogsInPrivilegeDefinitions: Boolean =
throw new SQLFeatureNotSupportedException
- override def supportsPositionedDelete: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsPositionedDelete: Boolean = false
- override def supportsPositionedUpdate: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsPositionedUpdate: Boolean = false
- override def supportsSelectForUpdate: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsSelectForUpdate: Boolean = false
- override def supportsStoredProcedures: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsStoredProcedures: Boolean = true
- override def supportsSubqueriesInComparisons: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsSubqueriesInComparisons: Boolean = true
- override def supportsSubqueriesInExists: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsSubqueriesInExists: Boolean = true
- override def supportsSubqueriesInIns: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsSubqueriesInIns: Boolean = true
- override def supportsSubqueriesInQuantifieds: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsSubqueriesInQuantifieds: Boolean = true
- override def supportsCorrelatedSubqueries: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsCorrelatedSubqueries: Boolean = true
- override def supportsUnion: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsUnion: Boolean = true
- override def supportsUnionAll: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsUnionAll: Boolean = true
- override def supportsOpenCursorsAcrossCommit: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsOpenCursorsAcrossCommit: Boolean = false
- override def supportsOpenCursorsAcrossRollback: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsOpenCursorsAcrossRollback: Boolean = false
- override def supportsOpenStatementsAcrossCommit: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsOpenStatementsAcrossCommit: Boolean = false
- override def supportsOpenStatementsAcrossRollback: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsOpenStatementsAcrossRollback: Boolean = false
- override def getMaxBinaryLiteralLength: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxBinaryLiteralLength: Int = 0
- override def getMaxCharLiteralLength: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxCharLiteralLength: Int = 0
- override def getMaxColumnNameLength: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxColumnNameLength: Int = 0
- override def getMaxColumnsInGroupBy: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxColumnsInGroupBy: Int = 0
- override def getMaxColumnsInIndex: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxColumnsInIndex: Int = 0
- override def getMaxColumnsInOrderBy: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxColumnsInOrderBy: Int = 0
- override def getMaxColumnsInSelect: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxColumnsInSelect: Int = 0
- override def getMaxColumnsInTable: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxColumnsInTable: Int = 0
- override def getMaxConnections: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxConnections: Int = 0
- override def getMaxCursorNameLength: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxCursorNameLength: Int = 0
- override def getMaxIndexLength: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxIndexLength: Int = 0
- override def getMaxSchemaNameLength: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxSchemaNameLength: Int = 0
- override def getMaxProcedureNameLength: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxProcedureNameLength: Int = 0
- override def getMaxCatalogNameLength: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxCatalogNameLength: Int = 0
- override def getMaxRowSize: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxRowSize: Int = 0
- override def doesMaxRowSizeIncludeBlobs: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def doesMaxRowSizeIncludeBlobs: Boolean = false
- override def getMaxStatementLength: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxStatementLength: Int = 0
- override def getMaxStatements: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxStatements: Int = 0
- override def getMaxTableNameLength: Int =
- throw new SQLFeatureNotSupportedException
+ override def getMaxTableNameLength: Int = 0
Review Comment:
ditto, 128 vs. unknown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
