pan3793 commented on code in PR #52741:
URL: https://github.com/apache/spark/pull/52741#discussion_r2464372216


##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectDatabaseMetaData.scala:
##########


Review Comment:
   Databricks JDBC v1.0.10-oss returns `false`, it violates the API contract.
   
   ```
      /**
        * Retrieves whether this database provides limited support for outer
        * joins.  (This will be {@code true} if the method
        * {@code supportsFullOuterJoins} returns {@code true}).
        *
        * @return {@code true} if so; {@code false} otherwise
        * @throws SQLException if a database access error occurs
        */
       boolean supportsLimitedOuterJoins() throws SQLException;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to