Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6707#discussion_r31981074
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/ReceivedBlockHandler.scala
---
@@ -32,7 +32,10 @@ import org.apache.spark.{Logging, SparkConf,
SparkException}
/** Trait that represents the metadata related to storage of blocks */
private[streaming] trait ReceivedBlockStoreResult {
- def blockId: StreamBlockId // Any implementation of this trait will
store a block id
+ // Any implementation of this trait will store a block id
+ def blockId: StreamBlockId
+ // Any implementation of this trait will have to return the number of
records
+ def numRecords: Option[Long]
--- End diff --
Ah, ok. I just find the `num*` method calls weird, when it could be called
`*count`. But if it is consistent with everything else, then it is fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
