Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/6707#discussion_r32296915
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/ReceivedBlockHandler.scala
---
@@ -151,13 +167,21 @@ private[streaming] class
WriteAheadLogBasedBlockHandler(
*/
def storeBlock(blockId: StreamBlockId, block: ReceivedBlock):
ReceivedBlockStoreResult = {
+ var numRecords = None: Option[Long]
// Serialize the block so that it can be inserted into both
val serializedBlock = block match {
case ArrayBufferBlock(arrayBuffer) =>
- blockManager.dataSerialize(blockId, arrayBuffer.iterator)
+ val countIterator = new CountingIterator(arrayBuffer.iterator)
--- End diff --
For ArrayBufferBlock, isnt it just easier to just get the count directly
rather than going through the CountingIterator again? Why even add the slightly
inefficiency of going through the counting iterator?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
