Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/6707#discussion_r32297172
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala
---
@@ -174,6 +186,183 @@ class ReceivedBlockHandlerSuite
}
}
+ test("BlockManagerBasedBlockHandler-MEMORY_ONLY-ByteBufferBlock - count
messages") {
+ storageLevel = StorageLevel.MEMORY_ONLY
+ // Create a non-trivial (not all zeros) byte array
+ val bytes = Array.tabulate(100)(i => i.toByte)
+ val byteBufferBlock = ByteBuffer.wrap(bytes)
+ withBlockManagerBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler,
ByteBufferBlock(byteBufferBlock))
+ // ByteBufferBlock is counted as single record
+ assert(blockStoreResult.numRecords === Some(1))
+ }
+ }
+
+ test("WriteAheadLogBasedBlockHandler-MEMORY_ONLY-ByteBufferBlock - count
messages") {
+ storageLevel = StorageLevel.MEMORY_ONLY
+ // Create a non-trivial (not all zeros) byte array
+ val bytes = Array.tabulate(100)(i => i.toByte)
+ val byteBufferBlock = ByteBuffer.wrap(bytes)
+ withWriteAheadLogBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler,
ByteBufferBlock(byteBufferBlock))
+ // ByteBufferBlock is counted as single record
+ assert(blockStoreResult.numRecords === Some(1))
+ }
+ }
+
+ test("BlockManagerBasedBlockHandler-MEMORY_ONLY-ArrayBufferBlock - count
messages") {
+ storageLevel = StorageLevel.MEMORY_ONLY
+ val block = ArrayBuffer.fill(100)(0)
+ withBlockManagerBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler, ArrayBufferBlock(block))
+ assert(blockStoreResult.numRecords === Some(100))
+ }
+ }
+
+ test("BlockManagerBasedBlockHandler-DISK_ONLY-ArrayBufferBlock - count
messages") {
+ storageLevel = StorageLevel.DISK_ONLY
+ val block = ArrayBuffer.fill(100)(0)
+ withBlockManagerBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler, ArrayBufferBlock(block))
+ assert(blockStoreResult.numRecords === Some(100))
+ }
+ }
+
+ test("BlockManagerBasedBlockHandler-MEMORY_AND_DISK-ArrayBufferBlock -
count messages") {
+ storageLevel = StorageLevel.MEMORY_AND_DISK
+ val block = ArrayBuffer.fill(100)(0)
+ withBlockManagerBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler, ArrayBufferBlock(block))
+ assert(blockStoreResult.numRecords === Some(100))
+ }
+ }
+
+ test("BlockManagerBasedBlockHandler-MEMORY_ONLY-IteratorBlock - count
messages") {
+ storageLevel = StorageLevel.MEMORY_ONLY
+ val block = ArrayBuffer.fill(100)(0)
+ withBlockManagerBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler,
IteratorBlock(block.iterator))
+ assert(blockStoreResult.numRecords === Some(100))
+ }
+ }
+
+ test("BlockManagerBasedBlockHandler-DISK_ONLY-IteratorBlock - count
messages") {
+ storageLevel = StorageLevel.DISK_ONLY
+ val block = ArrayBuffer.fill(100)(0)
+ withBlockManagerBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler,
IteratorBlock(block.iterator))
+ assert(blockStoreResult.numRecords === Some(100))
+ }
+ }
+
+ test("BlockManagerBasedBlockHandler-MEMORY_AND_DISK-IteratorBlock -
count messages") {
+ storageLevel = StorageLevel.MEMORY_AND_DISK
+ val block = ArrayBuffer.fill(100)(0)
+ withBlockManagerBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler,
IteratorBlock(block.iterator))
+ assert(blockStoreResult.numRecords === Some(100))
+ }
+ }
+
+ test("WriteAheadLogBasedBlockHandler-MEMORY_ONLY-ArrayBufferBlock -
count messages") {
+ storageLevel = StorageLevel.MEMORY_ONLY
+ val block = ArrayBuffer.fill(100)(0)
+ withWriteAheadLogBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler, ArrayBufferBlock(block))
+ assert(blockStoreResult.numRecords === Some(100))
+ }
+ }
+
+ test("WriteAheadLogBasedBlockHandler-DISK_ONLY-ArrayBufferBlock - count
messages") {
+ storageLevel = StorageLevel.DISK_ONLY
+ val block = ArrayBuffer.fill(100)(0)
+ withWriteAheadLogBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler, ArrayBufferBlock(block))
+ assert(blockStoreResult.numRecords === Some(100))
+ }
+ }
+
+ test("WriteAheadLogBasedBlockHandler-MEMORY_AND_DISK-ArrayBufferBlock -
count messages") {
+ storageLevel = StorageLevel.MEMORY_AND_DISK
+ val block = ArrayBuffer.fill(100)(0)
+ withWriteAheadLogBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler, ArrayBufferBlock(block))
+ assert(blockStoreResult.numRecords === Some(100))
+ }
+ }
+
+ test("WriteAheadLogBasedBlockHandler-MEMORY_ONLY-IteratorBlock - count
messages") {
+ storageLevel = StorageLevel.MEMORY_ONLY
+ val block = ArrayBuffer.fill(100)(0)
+ withWriteAheadLogBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler,
IteratorBlock(block.iterator))
+ assert(blockStoreResult.numRecords === Some(100))
+ }
+ }
+
+ test("WriteAheadLogBasedBlockHandler-DISK_ONLY-IteratorBlock - count
messages ") {
+ storageLevel = StorageLevel.DISK_ONLY
+ val block = ArrayBuffer.fill(100)(0)
+ withWriteAheadLogBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler,
IteratorBlock(block.iterator))
+ assert(blockStoreResult.numRecords === Some(100))
+ }
+ }
+
+ test("WriteAheadLogBasedBlockHandler-MEMORY_AND_DISK-IteratorBlock -
count messages") {
+ storageLevel = StorageLevel.MEMORY_AND_DISK
+ val block = ArrayBuffer.fill(100)(0)
+ withWriteAheadLogBasedBlockHandler { handler =>
+ val blockStoreResult = storeBlock(handler,
IteratorBlock(block.iterator))
+ assert(blockStoreResult.numRecords === Some(100))
+ }
+ }
+
+ test("BlockManagerBasedBlockHandler - isFullyConsumed-MEMORY_ONLY") {
+ storageLevel = StorageLevel.MEMORY_ONLY
+ blockManager = createBlockManager(12000)
+ val block = List.fill(70)(new Array[Byte](100))
+ // spark.storage.unrollFraction set to 0.4 for BlockManager
+ // With 12000 * 0.4 = 4800 bytes of free space for unroll , there is
not enough space to store
+ // this block With MEMORY_ONLY StorageLevel. BlockManager will not be
able to unroll this block
+ // and hence it will not tryToPut this block , resulting the
SparkException
+ withBlockManagerBasedBlockHandler { handler =>
+ val thrown = intercept[SparkException] {
+ val blockStoreResult = storeBlock(handler,
IteratorBlock(block.iterator))
+ }
+ assert(thrown.getMessage ===
+ "Could not store input-1-1000 to block manager with storage level
" + storageLevel)
+ }
+ }
+
+ test("BlockManagerBasedBlockHandler - isFullyConsumed-MEMORY_AND_DISK") {
+ storageLevel = StorageLevel.MEMORY_AND_DISK
+ blockManager = createBlockManager(12000)
+ val block = List.fill(70)(new Array[Byte](100))
+ // spark.storage.unrollFraction set to 0.4 for BlockManager
+ // With 12000 * 0.4 = 4800 bytes of free space for unroll , there is
not enough space to store
+ // this block in MEMORY , But BlockManager will be able to sereliaze
this block to DISK
--- End diff --
nit: extra space before , on both lines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
