pan3793 commented on code in PR #52988:
URL: https://github.com/apache/spark/pull/52988#discussion_r2512918714
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectResultSet.scala:
##########
@@ -76,6 +76,24 @@ class SparkConnectResultSet(
}
}
+ private[jdbc] def getColumnValue[T](index: Int, defaultVal: T)(getter: Int
=> T): T = {
+ checkOpen()
+ // the passed index value is 1-indexed, but the underlying array is
0-indexed
+ val columnIndex = index - 1
Review Comment:
can you swap the name between `columnIndex` and `index`? then, in the whole
source file, columnIndex is 1-based consistently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
