cty123 commented on code in PR #52988:
URL: https://github.com/apache/spark/pull/52988#discussion_r2512901515


##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectResultSet.scala:
##########
@@ -76,6 +76,22 @@ class SparkConnectResultSet(
     }
   }
 
+  private[jdbc] def getColumnValue[T](columnIndex: Int, defaultVal: T)(getter: 
Int => T): T = {
+    checkOpen()
+    if (columnIndex < 0 || columnIndex >= currentRow.length) {
+      throw new SQLException(s"The column index is out of range: $columnIndex, 
" +
+        s"number of columns: ${currentRow.length}.")

Review Comment:
   Oh, yes, value in the error message should be the value the user has passed 
in. I copied Postgresql driver for the error message. 
   
   ```java
   rs.getString(999)
   ```
   
   > Caused by: org.postgresql.util.PSQLException: The column index is out of 
range: 999, number of columns: 2.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to