dongjoon-hyun commented on code in PR #53019:
URL: https://github.com/apache/spark/pull/53019#discussion_r2519434305
##########
sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala:
##########
@@ -207,7 +207,7 @@ class InjectRuntimeFilterSuite extends QueryTest with
SQLTestUtils with SharedSp
// `MergeScalarSubqueries` can duplicate subqueries in the optimized plan
and would make testing
// complicated.
- conf.setConfString(SQLConf.OPTIMIZER_EXCLUDED_RULES.key,
MergeScalarSubqueries.ruleName)
+ conf.setConfString(SQLConf.OPTIMIZER_EXCLUDED_RULES.key,
MergeSubplans.ruleName)
Review Comment:
This also rings a bell to me. Is there a fallback plan for this improvement?
For example, can we exclude this new implement without a regression which means
keeping the existing `MergeScalarSubqueries`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
