dongjoon-hyun commented on code in PR #53019:
URL: https://github.com/apache/spark/pull/53019#discussion_r2519509379
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BloomFilterMightContain.scala:
##########
@@ -58,6 +59,7 @@ case class BloomFilterMightContain(
case GetStructField(subquery: PlanExpression[_], _, _)
if !subquery.containsPattern(OUTER_REFERENCE) =>
TypeCheckResult.TypeCheckSuccess
+ case _: ScalarSubqueryReference => TypeCheckResult.TypeCheckSuccess
Review Comment:
Orthogonal bug fix is also good because we can backport this unlike this PR.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BloomFilterMightContain.scala:
##########
@@ -58,6 +59,7 @@ case class BloomFilterMightContain(
case GetStructField(subquery: PlanExpression[_], _, _)
if !subquery.containsPattern(OUTER_REFERENCE) =>
TypeCheckResult.TypeCheckSuccess
+ case _: ScalarSubqueryReference => TypeCheckResult.TypeCheckSuccess
Review Comment:
Orthogonal bug fix is also good because we can backport this line unlike
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
