peter-toth commented on code in PR #53019:
URL: https://github.com/apache/spark/pull/53019#discussion_r2519510109
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkOptimizer.scala:
##########
@@ -61,8 +61,8 @@ class SparkOptimizer(
new RowLevelOperationRuntimeGroupFiltering(OptimizeSubqueries)),
Batch("InjectRuntimeFilter", FixedPoint(1),
InjectRuntimeFilter),
- Batch("MergeScalarSubqueries", Once,
- MergeScalarSubqueries,
+ Batch("MergeSubplans", Once,
+ MergeSubplans,
Review Comment:
BTW, I deliberately chose a generic new rule name like `MergeSubplans`
instead of something specific like `MergeOneRowResultSubplans`, as I'm hoping
that I can continue improving the rule in the future with
[SPARK-40193](https://issues.apache.org/jira/browse/SPARK-40193) /
https://github.com/apache/spark/pull/37630 to be able to merge different
filters; and then extend the rule to handle subplans that return multiple rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
