holdenk commented on code in PR #53009:
URL: https://github.com/apache/spark/pull/53009#discussion_r2529237754


##########
sql/api/src/main/scala/org/apache/spark/sql/types/GeometryType.scala:
##########
@@ -161,13 +161,13 @@ object GeometryType extends SpatialType {
    * Parquet, Delta, and Iceberg specifications. If crs is omitted, it should 
always default to
    * this.
    */
-  final val GEOMETRY_DEFAULT_SRID = 4326
-  final val GEOMETRY_DEFAULT_CRS = "OGC:CRS84"
+  final lazy val GEOMETRY_DEFAULT_SRID = 4326
+  final lazy val GEOMETRY_DEFAULT_CRS = "OGC:CRS84"

Review Comment:
   these are final vals that are hard coded, I don't think lazy makes sense here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to