uros-db commented on code in PR #53009:
URL: https://github.com/apache/spark/pull/53009#discussion_r2534217728
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/encoders/AgnosticEncoder.scala:
##########
@@ -279,9 +279,9 @@ object AgnosticEncoders {
ScalaDecimalEncoder(DecimalType.SYSTEM_DEFAULT)
val DEFAULT_JAVA_DECIMAL_ENCODER: JavaDecimalEncoder =
JavaDecimalEncoder(DecimalType.SYSTEM_DEFAULT, lenientSerialization =
false)
- val DEFAULT_GEOMETRY_ENCODER: GeometryEncoder =
+ lazy val DEFAULT_GEOMETRY_ENCODER: GeometryEncoder =
Review Comment:
Thanks, removed this.
##########
sql/api/src/main/scala/org/apache/spark/sql/types/GeographyType.scala:
##########
@@ -163,19 +163,19 @@ object GeographyType extends SpatialType {
* Default CRS value for GeographyType depends on storage specification.
Parquet and Iceberg use
* OGC:CRS84, which translates to SRID 4326 here.
*/
- final val GEOGRAPHY_DEFAULT_SRID = 4326
- final val GEOGRAPHY_DEFAULT_CRS = "OGC:CRS84"
+ final lazy val GEOGRAPHY_DEFAULT_SRID = 4326
+ final lazy val GEOGRAPHY_DEFAULT_CRS = "OGC:CRS84"
// The default edge interpolation algorithm value for GeographyType.
- final val GEOGRAPHY_DEFAULT_ALGORITHM = EdgeInterpolationAlgorithm.SPHERICAL
+ final lazy val GEOGRAPHY_DEFAULT_ALGORITHM =
EdgeInterpolationAlgorithm.SPHERICAL
// Another way to represent the default parquet crs value (OGC:CRS84).
- final val GEOGRAPHY_DEFAULT_EPSG_CRS = s"EPSG:$GEOGRAPHY_DEFAULT_SRID"
+ final lazy val GEOGRAPHY_DEFAULT_EPSG_CRS = s"EPSG:$GEOGRAPHY_DEFAULT_SRID"
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
