uros-db commented on code in PR #53009:
URL: https://github.com/apache/spark/pull/53009#discussion_r2534218780
##########
sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/arrow/ArrowEncoderSuite.scala:
##########
@@ -41,24 +41,30 @@ import
org.apache.spark.sql.catalyst.util.DateTimeConstants.MICROS_PER_SECOND
import org.apache.spark.sql.catalyst.util.IntervalStringStyles.ANSI_STYLE
import org.apache.spark.sql.catalyst.util.SparkDateTimeUtils._
import org.apache.spark.sql.catalyst.util.SparkIntervalUtils._
+import org.apache.spark.sql.connect.SparkSession
import org.apache.spark.sql.connect.client.CloseableIterator
import org.apache.spark.sql.connect.client.arrow.FooEnum.FooEnum
-import org.apache.spark.sql.connect.test.ConnectFunSuite
+import org.apache.spark.sql.connect.test.{ConnectFunSuite, RemoteSparkSession}
import org.apache.spark.sql.types.{ArrayType, DataType, DayTimeIntervalType,
Decimal, DecimalType, Geography, Geometry, IntegerType, Metadata,
SQLUserDefinedType, StringType, StructType, UserDefinedType,
YearMonthIntervalType}
import org.apache.spark.unsafe.types.VariantVal
import org.apache.spark.util.{MaybeNull, SparkStringUtils}
/**
* Tests for encoding external data to and from arrow.
*/
-class ArrowEncoderSuite extends ConnectFunSuite with BeforeAndAfterAll {
+class ArrowEncoderSuite extends ConnectFunSuite with RemoteSparkSession with
BeforeAndAfterAll {
private val allocator = new RootAllocator()
private def newAllocator(name: String): BufferAllocator = {
allocator.newChildAllocator(name, 0, allocator.getLimit)
}
- protected override def afterAll(): Unit = {
+ override def beforeAll(): Unit = {
+ super.beforeAll()
+ SparkSession.getActiveSession.get.conf.set("spark.sql.geospatial.enabled",
"true")
+ }
Review Comment:
Removed.
##########
sql/api/src/main/scala/org/apache/spark/sql/types/GeometryType.scala:
##########
@@ -161,13 +161,13 @@ object GeometryType extends SpatialType {
* Parquet, Delta, and Iceberg specifications. If crs is omitted, it should
always default to
* this.
*/
- final val GEOMETRY_DEFAULT_SRID = 4326
- final val GEOMETRY_DEFAULT_CRS = "OGC:CRS84"
+ final lazy val GEOMETRY_DEFAULT_SRID = 4326
+ final lazy val GEOMETRY_DEFAULT_CRS = "OGC:CRS84"
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
